Next

.eslintrc.cjs

@@ -4,21 +4,31 @@
  */
 module.exports = {
 	extends: [
-		'@nextcloud',
+		'@nextcloud/eslint-config/vue3',
 		'prettier',
 	],
 	plugins: [
 		'promise',
 	],
 	rules: {
 		'arrow-body-style': 'error',
+		"jsdoc/require-jsdoc": ["error" | "warn", {
+			"publicOnly": {
+				"ancestorsOnly": true,
+			},
+		}],
 		'no-array-constructor': 'error',
 		'no-continue': 'error',
 		'no-else-return': ['error', { allowElseIf: false }],
 		'no-lonely-if': 'error',
 		'no-negated-condition': 'error',
 		'no-plusplus': ['error', { allowForLoopAfterthoughts: true }],
 		'prefer-template': 'error',
+		'vue/script-indent': ['error', 'tab', {
+			baseIndent: 1,
+			switchCase: 1,
+		}],
+		'vue/no-v-model-argument': 'off',
 		'vue/no-unused-properties': ['error', {
 			groups: ['props', 'data', 'computed', 'methods'],
 			deepData: true,

.github/BETA_NOTIFICATION.md

@@ -1,7 +1,3 @@
-<!--
- - SPDX-FileCopyrightText: 2023 Nextcloud contributors
- - SPDX-License-Identifier: AGPL-3.0-or-later
--->
 ---
 title: Polls {{ env.VERSION }} released ({{ date | date('YYYY-MM-DD') }})
 labels: Announcement

.github/BETA_NOTIFICATION.md.license

@@ -0,0 +1,2 @@
+SPDX-FileCopyrightText: 2023 Nextcloud contributors
+SPDX-License-Identifier: AGPL-3.0-or-later

.github/ISSUE_TEMPLATE/BUG_REPORT.yml

@@ -151,11 +151,11 @@ body:
       description: |
         Which Nextcloud Server version are you running.
       options:
-        - "Nextcloud 25"
-        - "Nextcloud 26"
         - "Nextcloud 27"
         - "Nextcloud 28"
         - "Nextcloud 29"
+        - "Nextcloud 30"
+        - "Nextcloud 31"
         - "Other/Don't know"
     validations:
       required: true
@@ -184,7 +184,7 @@ body:
     attributes:
       label: Other PHP version
       description: Add your _other_ PHP versoin
-      placeholder: i.e. PHP 7.4
+      placeholder: i.e. PHP 8.3
 
   - type: dropdown
     id: server-database

.github/RELEASE_NOTIFICATION.md

@@ -1,7 +1,3 @@
-<!--
- - SPDX-FileCopyrightText: 2023 Nextcloud contributors
- - SPDX-License-Identifier: AGPL-3.0-or-later
--->
 ---
 title: Polls {{ env.VERSION }} released ({{ date | date('YYYY-MM-DD') }})
 labels: Announcement

.github/RELEASE_NOTIFICATION.md.license

@@ -0,0 +1,2 @@
+SPDX-FileCopyrightText: 2023 Nextcloud contributors
+SPDX-License-Identifier: AGPL-3.0-or-later

.github/actions/get-polls-version/action.yml

@@ -21,7 +21,7 @@ runs:
   steps:
     - name: Get app version from appinfo/info.xml
       id: appinfo
-      uses: mavrosxristoforos/get-xml-info@1.1.1
+      uses: mavrosxristoforos/get-xml-info@2.0
       with:
         xml-file: 'appinfo/info.xml'
         xpath: '//info//version'

.github/actions/setup-composer/action.yml

@@ -3,9 +3,9 @@
 name: Setup composer and PHP
 inputs:
   php-version:
-    description: 'PHP version (default: 8.0)'
+    description: 'PHP version (default: 8.2)'
     required: false
-    default: '8.0'
+    default: '8.2'
   php-tools:
     description: 'Additional php tools'
     required: false

.github/actions/setup-server/action.yml

@@ -12,8 +12,8 @@ inputs:
     description: 'App to checkout (default: polls)'
   php-version:
     required: false
-    default: '8.0'
-    description: 'PHP version (default: 8.0)'
+    default: '8.2'
+    description: 'PHP version (default: 8.2)'
   php-tools:
     description: 'Additional php tools'
     required: false

.github/workflows/appstore-build-publish.yml

@@ -0,0 +1,175 @@
+# This workflow is provided via the organization template repository
+#
+# https://github.com/nextcloud/.github
+# https://docs.github.com/en/actions/learn-github-actions/sharing-workflows-with-your-organization
+#
+# SPDX-FileCopyrightText: 2021-2024 Nextcloud GmbH and Nextcloud contributors
+# SPDX-License-Identifier: MIT
+
+name: Build and publish app release
+
+on:
+  release:
+    types: [published]
+
+jobs:
+  build_and_publish:
+    runs-on: ubuntu-latest
+
+    # Only allowed to be run on nextcloud-releases repositories
+    if: ${{ github.repository_owner == 'nextcloud-releases' }}
+
+    steps:
+      - name: Check actor permission
+        uses: skjnldsv/check-actor-permission@69e92a3c4711150929bca9fcf34448c5bf5526e7 # v3.0
+        with:
+          require: write
+
+      - name: Set app env
+        run: |
+          # Split and keep last
+          echo "APP_NAME=${GITHUB_REPOSITORY##*/}" >> $GITHUB_ENV
+          echo "APP_VERSION=${GITHUB_REF##*/}" >> $GITHUB_ENV
+
+      - name: Checkout
+        uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
+        with:
+          path: ${{ env.APP_NAME }}
+
+      - name: Get appinfo data
+        id: appinfo
+        uses: skjnldsv/xpath-action@7e6a7c379d0e9abc8acaef43df403ab4fc4f770c # master
+        with:
+          filename: ${{ env.APP_NAME }}/appinfo/info.xml
+          expression: "//info//dependencies//nextcloud/@min-version"
+
+      - name: Read package.json node and npm engines version
+        uses: skjnldsv/read-package-engines-version-actions@06d6baf7d8f41934ab630e97d9e6c0bc9c9ac5e4 # v3
+        id: versions
+        # Continue if no package.json
+        continue-on-error: true
+        with:
+          path: ${{ env.APP_NAME }}
+          fallbackNode: '^20'
+          fallbackNpm: '^10'
+
+      - name: Set up node ${{ steps.versions.outputs.nodeVersion }}
+        # Skip if no package.json
+        if: ${{ steps.versions.outputs.nodeVersion }}
+        uses: actions/setup-node@1e60f620b9541d16bece96c5465dc8ee9832be0b # v4.0.3
+        with:
+          node-version: ${{ steps.versions.outputs.nodeVersion }}
+
+      - name: Set up npm ${{ steps.versions.outputs.npmVersion }}
+        # Skip if no package.json
+        if: ${{ steps.versions.outputs.npmVersion }}
+        run: npm i -g 'npm@${{ steps.versions.outputs.npmVersion }}'
+
+      - name: Get php version
+        id: php-versions
+        uses: icewind1991/nextcloud-version-matrix@58becf3b4bb6dc6cef677b15e2fd8e7d48c0908f # v1.3.1
+        with:
+          filename: ${{ env.APP_NAME }}/appinfo/info.xml
+
+      - name: Set up php ${{ steps.php-versions.outputs.php-min }}
+        uses: shivammathur/setup-php@c541c155eee45413f5b09a52248675b1a2575231 # v2.31.1
+        with:
+          php-version: ${{ steps.php-versions.outputs.php-min }}
+          coverage: none
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+
+      - name: Check composer.json
+        id: check_composer
+        uses: andstor/file-existence-action@076e0072799f4942c8bc574a82233e1e4d13e9d6 # v3.0.0
+        with:
+          files: "${{ env.APP_NAME }}/composer.json"
+
+      - name: Install composer dependencies
+        if: steps.check_composer.outputs.files_exists == 'true'
+        run: |
+          cd ${{ env.APP_NAME }}
+          composer install --no-dev
+
+      - name: Build ${{ env.APP_NAME }}
+        # Skip if no package.json
+        if: ${{ steps.versions.outputs.nodeVersion }}
+        env:
+          CYPRESS_INSTALL_BINARY: 0
+        run: |
+          cd ${{ env.APP_NAME }}
+          npm ci
+          npm run build --if-present
+
+      - name: Check Krankerl config
+        id: krankerl
+        uses: andstor/file-existence-action@076e0072799f4942c8bc574a82233e1e4d13e9d6 # v3.0.0
+        with:
+          files: ${{ env.APP_NAME }}/krankerl.toml
+
+      - name: Install Krankerl
+        if: steps.krankerl.outputs.files_exists == 'true'
+        run: |
+          wget https://github.com/ChristophWurst/krankerl/releases/download/v0.14.0/krankerl_0.14.0_amd64.deb
+          sudo dpkg -i krankerl_0.14.0_amd64.deb
+
+      - name: Package ${{ env.APP_NAME }} ${{ env.APP_VERSION }} with krankerl
+        if: steps.krankerl.outputs.files_exists == 'true'
+        run: |
+          cd ${{ env.APP_NAME }}
+          krankerl package
+
+      - name: Package ${{ env.APP_NAME }} ${{ env.APP_VERSION }} with makefile
+        if: steps.krankerl.outputs.files_exists != 'true'
+        run: |
+          cd ${{ env.APP_NAME }}
+          make appstore
+
+      - name: Checkout server ${{ fromJSON(steps.appinfo.outputs.result).nextcloud.min-version }}
+        continue-on-error: true
+        id: server-checkout
+        run: |
+          NCVERSION='${{ fromJSON(steps.appinfo.outputs.result).nextcloud.min-version }}'
+          wget --quiet https://download.nextcloud.com/server/releases/latest-$NCVERSION.zip
+          unzip latest-$NCVERSION.zip
+
+      - name: Checkout server master fallback
+        uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
+        if: ${{ steps.server-checkout.outcome != 'success' }}
+        with:
+          submodules: true
+          repository: nextcloud/server
+          path: nextcloud
+
+      - name: Sign app
+        run: |
+          # Extracting release
+          cd ${{ env.APP_NAME }}/build/artifacts/appstore
+          tar -xvf ${{ env.APP_NAME }}.tar.gz
+          cd ../../../../
+          # Setting up keys
+          echo '${{ secrets.APP_PRIVATE_KEY }}' > ${{ env.APP_NAME }}.key
+          wget --quiet "https://github.com/nextcloud/app-certificate-requests/raw/master/${{ env.APP_NAME }}/${{ env.APP_NAME }}.crt"
+          # Signing
+          php nextcloud/occ integrity:sign-app --privateKey=../${{ env.APP_NAME }}.key --certificate=../${{ env.APP_NAME }}.crt --path=../${{ env.APP_NAME }}/build/artifacts/appstore/${{ env.APP_NAME }}
+          # Rebuilding archive
+          cd ${{ env.APP_NAME }}/build/artifacts/appstore
+          tar -zcvf ${{ env.APP_NAME }}.tar.gz ${{ env.APP_NAME }}
+
+      - name: Attach tarball to github release
+        uses: svenstaro/upload-release-action@04733e069f2d7f7f0b4aebc4fbdbce8613b03ccd # v2
+        id: attach_to_release
+        with:
+          repo_token: ${{ secrets.GITHUB_TOKEN }}
+          file: ${{ env.APP_NAME }}/build/artifacts/appstore/${{ env.APP_NAME }}.tar.gz
+          asset_name: ${{ env.APP_NAME }}-${{ env.APP_VERSION }}.tar.gz
+          tag: ${{ github.ref }}
+          overwrite: true
+
+      - name: Upload app to Nextcloud appstore
+        uses: nextcloud-releases/nextcloud-appstore-push-action@a011fe619bcf6e77ddebc96f9908e1af4071b9c1 # v1
+        with:
+          app_name: ${{ env.APP_NAME }}
+          appstore_token: ${{ secrets.APPSTORE_TOKEN }}
+          download_url: ${{ steps.attach_to_release.outputs.browser_download_url }}
+          app_private_key: ${{ secrets.APP_PRIVATE_KEY }}

.github/workflows/pr-feedback.yml

@@ -28,7 +28,7 @@ jobs:
         with:
           feedback-message: |
             Hello there,
-            Thank you so much for taking the time and effort to create a pull request to our Nextcloud project. 
+            Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.
 
             We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.
 

.github/workflows/publish_alpha.yml

@@ -0,0 +1,64 @@
+# SPDX-FileCopyrightText: 2022 Nextcloud contributors
+# SPDX-License-Identifier: AGPL-3.0-or-later
+name: Publish alpha
+
+on: 
+  push:
+    tags:
+      - v*-alpha*
+
+jobs:
+  checkout:
+    runs-on: ubuntu-latest
+    name: Alpha release
+    steps:
+    - uses: actions/checkout@v4
+    - name: Check correct app version
+      id: appinfo
+      uses: ./.github/actions/get-polls-version
+
+    - name: Setup node
+      if: success()
+      uses: ./.github/actions/setup-node
+
+    - name: Setup composer and PHP
+      if: success()
+      uses: ./.github/actions/setup-composer
+      with:
+        mode: production
+        php-tools: composer
+
+    - name: build
+      run: npm run dev --if-present
+
+    - name: Make appstore package ${{ steps.appinfo.outputs.app-version }}
+      if: success()
+      run: make package
+
+    - name: rename packages to polls-${{ steps.appinfo.outputs.app-version }}
+      if: success()
+      run: mv build/artifacts/appstore/polls.tar.gz build/artifacts/appstore/polls-${{ steps.appinfo.outputs.app-version }}.tar.gz
+
+    - name: create zip archive from sources
+      if: success()
+      run: |
+        pushd build/source
+        zip -r ../artifacts/appstore/polls-${{ steps.appinfo.outputs.app-version }}.zip *
+        popd
+
+    - name: Extract release notes
+      if: success()
+      id: extract-release-notes
+      uses: ffurrer2/extract-release-notes@v1
+
+    - name: Publish pre-release ${{ steps.appinfo.outputs.app-version }}
+      if: success()
+      uses: softprops/action-gh-release@v1
+      with:
+        body: "# Changelog for the upcomming release (preview)\n ${{ steps.extract-release-notes.outputs.release_notes }} "
+        prerelease: true
+        draft: false
+        generate_release_notes: true
+        files: |
+          build/artifacts/appstore/polls-${{ steps.appinfo.outputs.app-version }}.tar.gz
+          build/artifacts/appstore/polls-${{ steps.appinfo.outputs.app-version }}.zip

.github/workflows/reuse.yml

@@ -9,12 +9,14 @@
 
 name: REUSE Compliance Check
 
-on: pull_request
+on: [pull_request]
 
 jobs:
   reuse-compliance-check:
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@44c2b7a8a4ea60a981eaca3cf939b5f4305c123b # v4.1.5
+    - name: Checkout
+      uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
+
     - name: REUSE Compliance Check
-      uses: fsfe/reuse-action@a46482ca367aef4454a87620aa37c2be4b2f8106 # v3.0.0
+      uses: fsfe/reuse-action@3ae3c6bdf1257ab19397fab11fd3312144692083 # v4.0.0

.github/workflows/static-analysis.yml

@@ -15,7 +15,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        ocp-version: ['master']
+        ocp-version: ['stable29']
         php-versions: ['8.1', '8.2', '8.3']
 
     name: Psalm
@@ -30,10 +30,10 @@ jobs:
           php-tools: composer
 
       - name: Install Nextcloud API
-        run: composer require --dev nextcloud/ocp:dev-${{ matrix.ocp-version }}
+        run: composer require --dev -W nextcloud/ocp:dev-${{ matrix.ocp-version }}
 
       - name: Install symfony/console
-        run: composer require symfony/console
+        run: composer require -W symfony/console
 
       - name: Run coding standards check
         run: composer run psalm