Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Ask for feedback on PRs ' #3013

Merged
merged 1 commit into from
Aug 21, 2023
Merged

Add 'Ask for feedback on PRs ' #3013

merged 1 commit into from
Aug 21, 2023

Conversation

hamza221
Copy link
Contributor

@hamza221 hamza221 commented Aug 5, 2023

No description provided.

Copy link
Collaborator

@dartcafe dartcafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes no sense here, since this app is not maintained by Nextcloud

@ChristophWurst
Copy link
Member

This makes no sense here, since this app is not maintained by Nextcloud

@DaphneMuller ^

@ChristophWurst ChristophWurst requested review from DaphneMuller and removed request for ChristophWurst August 7, 2023 08:26
@github-actions github-actions bot added the stale label Aug 9, 2023
@dartcafe dartcafe removed the stale label Aug 9, 2023
@DaphneMuller
Copy link

the app is in our spreadsheet though with Hamza as contact person, so please figure that out with Andy if needed and otherwise please merge :)

@hamza221
Copy link
Contributor Author

Even though Polls is primarily maintained by community namely @dartcafe, it can still provide insight how Nextcloud as a company is seen from a supporting side for contributors.

@dartcafe
Copy link
Collaborator

I have no problem with that, but reviews are rather rare here, since the community contribution in PRs is poor. I was just wondering, if this is helpful.

@hamza221
Copy link
Contributor Author

@dartcafe the failing check is unrelated right?

@dartcafe dartcafe self-requested a review August 21, 2023 06:55
@dartcafe
Copy link
Collaborator

dartcafe commented Aug 21, 2023

@dartcafe the failing check is unrelated right?

Yep. Was a failed container. Re-run fixed it

@hamza221 hamza221 merged commit f9ed685 into master Aug 21, 2023
15 checks passed
@delete-merged-branch delete-merged-branch bot deleted the Pr-feedback branch August 21, 2023 06:57
@dartcafe
Copy link
Collaborator

dartcafe commented Mar 28, 2024

@hamza221 Are you aware, that this action dies before all issues/prs are processed?

Does it make sense, that all issues starting by no. 1 are processed?

Batch  #29  processed.
Processing the batch of issues  #30  containing  100  issues...
Warning: No more operations left! Exiting...
Warning: If you think that not enough issues were processed you could try to increase the quantity related to the  operations-per-run (​[https://github.com/actions/stale#operations-per-run​)](https://github.com/actions/stale#operations-per-run%E2%80%8B))  option which is currently set to  30
Statistics:
Processed items: 2900
├── Processed issues: 1056
└── Processed PRs   : 1844
Fetched items: 3000
Operations performed: 30

https://github.com/nextcloud/polls/actions/runs/8461346634/job/23180971213#step:3:17213

@hamza221
Copy link
Contributor Author

cc @marcelklehr

@marcelklehr
Copy link
Member

Ahoy! Nice catch. When the issue count is higher than 3000 the action stops catching new PRs. I've updated it now to fix this. PR is here: #3397

Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants