fixes

Signed-off-by: dartcafe <[email protected]>
nextcloud · Aug 4, 2023 · a224c7c · a224c7c
1 parent 4b12e92
commit a224c7c
Show file tree

Hide file tree

Showing 5 changed files with 3 additions and 10 deletions.
diff --git a/lib/Controller/PollApiController.php b/lib/Controller/PollApiController.php
@@ -178,7 +178,7 @@ public function transferPolls(string $sourceUser, string $destinationUser): JSON
 	 * @param int $pollId Poll to transfer
 	 * @param string $destinationUser User to transfer the poll to
 	 */
-	public function transferPoll(string $pollId, string $destinationUser): JSONResponse {
+	public function transferPoll(int $pollId, string $destinationUser): JSONResponse {
 		try {
 			return new JSONResponse(['transferred' => $this->pollService->transferPoll($pollId, $destinationUser)], Http::STATUS_CREATED);
 		} catch (Exception $e) {

diff --git a/lib/Controller/ShareController.php b/lib/Controller/ShareController.php
@@ -57,7 +57,7 @@ public function list(int $pollId): JSONResponse {
 	 * Add share
 	 * @NoAdminRequired
 	 */
-	public function add(int $pollId, string $type, string $userId = '', string $displayName = '', string $emailAddress = '' ): JSONResponse {
+	public function add(int $pollId, string $type, string $userId = '', string $displayName = '', string $emailAddress = ''): JSONResponse {
 		return $this->responseCreate(fn () => ['share' => $this->shareService->add($pollId, $type, $userId, $displayName, $emailAddress)]);
 	}
 

diff --git a/lib/Controller/SubscriptionApiController.php b/lib/Controller/SubscriptionApiController.php
@@ -26,7 +26,6 @@
 use OCA\Polls\Exceptions\Exception;
 use OCA\Polls\Model\Acl;
 use OCA\Polls\Service\SubscriptionService;
-use OCP\AppFramework\Db\DoesNotExistException;
 use OCP\AppFramework\Http;
 use OCP\AppFramework\Http\JSONResponse;
 use OCP\IRequest;

diff --git a/lib/Service/OptionService.php b/lib/Service/OptionService.php
@@ -250,7 +250,7 @@ public function confirm(int $optionId): Option {
 		return $this->option;
 	}
 
-	private function getModifiedDateOption(Option $option, DateTimeZone $timeZone, int $step, string $unit) {
+	private function getModifiedDateOption(Option $option, DateTimeZone $timeZone, int $step, string $unit): array {
 		$from = (new DateTime())
 			->setTimestamp($option->getTimestamp())
 			->setTimezone($timeZone)
@@ -266,10 +266,6 @@ private function getModifiedDateOption(Option $option, DateTimeZone $timeZone, i
 		];
 	}
 
-	private function cloneOption() {
-		return clone $this->option;
-	}
-
 	/**
 	 * Make a sequence of date poll options
 	 *

diff --git a/lib/Service/PollService.php b/lib/Service/PollService.php
@@ -185,8 +185,6 @@ public function transferPolls(string $sourceUser, string $targetUser): array {
 
 	/**
 	 * @return Poll
-	 *
-	 * @psalm-return array<Poll>
 	 */
 	public function transferPoll(int $pollId, string $targetUser): Poll {
 		if ($this->userManager->get($targetUser) instanceof IUser) {