Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add clarifying use case details to appstore #590

Merged
merged 2 commits into from
Oct 1, 2024
Merged

fix: add clarifying use case details to appstore #590

merged 2 commits into from
Oct 1, 2024

Conversation

joshtrichards
Copy link
Member

  • Target version: main

Summary

Add a tiny bit more info to the app store description so that:

  • it's not confused with Nextcloud Office or CODE
  • it's clearer it works with Office Online Server (self-hosted) not cloud

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Documentation (manuals or wiki) has been updated or is not required

@joshtrichards joshtrichards added 3. to review Waiting for reviews enhancement New feature or request labels Sep 12, 2024
@nickvergessen nickvergessen removed their request for review September 12, 2024 22:19
max-nextcloud
max-nextcloud requested changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@max-nextcloud max-nextcloud left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joshtrichards Thanks for adding the context here. Looks like something is wrong with the syntax though. (Or our linter is overly picky)

Bildschirmfoto vom 2024-10-01 11-55-49

You can also check this locally:

wget https://apps.nextcloud.com/schema/apps/info.xsd
xmllint appinfo/info.xml --schema info.xsd

@max-nextcloud max-nextcloud self-requested a review October 1, 2024 15:16
max-nextcloud
max-nextcloud approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@max-nextcloud max-nextcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice... Looks good now. Failing tests is unrelated.

@max-nextcloud max-nextcloud merged commit 602820e into main Oct 1, 2024
43 of 44 checks passed
@max-nextcloud max-nextcloud deleted the jtr/appstore-description branch October 1, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-nextcloud max-nextcloud max-nextcloud approved these changes

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees
No one assigned
Labels
3. to review Waiting for reviews enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshtrichards @max-nextcloud