fix(UI): script to register at viewer has to require viewer #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@juliushaertl we discussed the problem i was facing yesterday. with this change, i can open documents properly now on the dev setup. |
juliusknorr
reviewed
May 14, 2024
There was a problem hiding this comment.
We should probably rather make use of nextcloud/server#30015 and add viewer as 3rd parameter to https://github.com/nextcloud/officeonline/blob/main/lib/Listener/LoadViewerListener.php#L13 so that the officeonline script is only loaded after viewer has been.
Cool. Did not know we have that. |
avoids conditions where registering is attempted when OCA.Viewer is not established yet Signed-off-by: Arthur Schiwon <[email protected]>
blizzz
force-pushed
the
fix/noid/what-for-viewer
branch
from
cfcc17f
to
6202017
Compare
|
Changed the PR accordingly. |
blizzz
changed the title
juliusknorr
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
avoids conditions where registering is attempted when OCA.Viewer is not established yet
Checklist