-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Category: Add new category button to create new folders #1002
base: main
Are you sure you want to change the base?
Conversation
Maybe we can Have a separate clear category button? Otherwise I could imagine this would be good to fix upstream in the library in a follow up.
Seems reasonable, I don#t think there is need for any separate API here if we can use standard webdav.
I think this would be ok, we might want to discuss separately how we handle different file extensions with the new rich editor, especially if .txt files should rather be opened in plain text editing mode rather than also markdown. |
Just noticed that showing all categories is at least an option as part of the 3-column layout in 4412195 |
Yeah, we could simply also show categories without notes in them, that is fine. If the folder exists it should be shown. :) And design-wise yep, this depends a bunch on the 3-column layout. With the switch to that, we don’t need this whole expand and collapse mechanic anymore, as the folder/category list is the only thing in the left navigation. |
97ef671
to
1ec0f5a
Compare
Another ping here @juliushaertl does this need to await the redesign to the 3 column layout ? Are they any open tasks that I can implemend here ? |
We merged the three column layout end of last week, i think this change would be a great addition to rebase on top. Regarding other tasks it mostly depends on your interest, we are generally open to any feature contribution, if there is an issue if of course might make sense to discuss ideas first to also align with our designers about potential UX topics. We also have a chatroom for contributors on our Nextcloud instance, in case you are interested in joining for some exchange feel free to drop me an email to |
notes path for categories. Signed-off-by: Jonathan Pagel <[email protected]>
…rent notes path for categories.
1ec0f5a
to
7593066
Compare
Following #967 I added an action in the navigation item
Categories
for adding new folders in the current notes path acting as categories.Some remarks:
remote.php
api end-point like the files app, but I am unsure if there is a more elegant way https://github.com/nextcloud/server/blob/55ba9601f2ef5b14524693a77c59cb7f7174270c/apps/files/src/utils/davUtils.jsNcActionInput
like the calendar app, but I had trouble to get the trailing submit arrow working, because it only works if the value isn't empty at rendering.. https://github.com/nextcloud/nextcloud-vue/blob/c269d6a3c255f6c62cdefe9407f3756911ee8964/src/components/NcActionInput/NcActionInput.vue#L221This gifs show the workflow and an error case, if a folder with that name already exist (but may not listed in categories if the folder is empty)