fix(nextcloud)!: tables row endpoints #2509
Draft
+264
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nikolas Rimikis <[email protected]>
Signed-off-by: Nikolas Rimikis <[email protected]>
Leptopoda
changed the title
|
Marking as a draft because the specs are just fundamentally broken and will require upstream changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #2508
CAUTION: I just took a look at the returned data and changed the spec to match that. It might still be possible that the api returns something different that doesn't match the patched spec.
Consulting the tables source code wasn't an option, as the wrong typing likely originates from it (no information to gain there).
I'm not sure how to move forward from here.
I don't have any confidence that the specs for that api are of any use. When something as fundamental as the typing of the row data is wrong, there are likely many more issues to be found. I dislike having to make a breaking release every time we try to fix it.
We might need to remove the tables client from the Nextcloud package again.