Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): Validate code generation #1048

Merged
merged 1 commit into from
Oct 29, 2023

Conversation

provokateurin
Copy link
Member

Closes #555
Replaces #1014

Copy link
Member

@Leptopoda Leptopoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also remove the build_verify dependency in dynamite_e2e

.github/workflows/generate.yml Outdated Show resolved Hide resolved
.github/workflows/generate.yml Outdated Show resolved Hide resolved
@provokateurin provokateurin force-pushed the feature/ci/validate-generation branch 4 times, most recently from 81d3de8 to e215b73 Compare October 29, 2023 07:24
@provokateurin provokateurin marked this pull request as ready for review October 29, 2023 07:28
@provokateurin provokateurin force-pushed the feature/ci/validate-generation branch 2 times, most recently from c4e2b66 to 16e8584 Compare October 29, 2023 07:34
@provokateurin
Copy link
Member Author

With skipping instead of filtering we can set the workflow to be required which is good to avoid accidental merges with red CI.

@provokateurin
Copy link
Member Author

@Leptopoda Ready for review

@provokateurin provokateurin merged commit f04462d into main Oct 29, 2023
9 checks passed
@provokateurin provokateurin deleted the feature/ci/validate-generation branch October 29, 2023 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CI workflow to check that all generated things are up-to-date
2 participants