-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop using ...[]
pattern (spread list)
#696
Comments
Instead external lists should be used. |
...[]
pattern...[]
pattern (spread list)
This now only affects |
We could add a CI script regex that checks for this. Though there are some legitimate uses (but maybe we can avoid all of them?) |
I think we can avoid most of them as you might be able to see in my upcoming PR (I'll make a draft shortly). I don't think CI is needed. The dashboard app is the first one developed to our current code style and standard and it already doesn't make use of this pattern. And for now you can count on my reviews as I really hate this pattern when missused. |
I don't think that this needs to be in the first app release. |
This is rarely used anymore and the few remaining places are not performance sensitive. |
I suggest either using a generator function (the
sync*
yield
stuff, which probably isn't fitting) or add acategories
variable and conditionally add elements withcategories.add()
Originally posted by @Leptopoda in #600 (comment)
The text was updated successfully, but these errors were encountered: