Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor settings #849

Open
Leptopoda opened this issue Sep 25, 2023 · 0 comments
Open

Refactor settings #849

Leptopoda opened this issue Sep 25, 2023 · 0 comments
Labels
package: neon_framework refactoring Something that needs to be refactored

Comments

@Leptopoda
Copy link
Member

The settings code both has a bad api and even worse performance.
When rewriting we should also take into account a possible iOS design.

To clean up the code we could add a boolean field to Option controlling whether it is supported. The settings list could have a generator function that would dismiss unsupported options and empty option categories (related to #696 ).
An unsupported option could also be optimized by adding early returns to the setters potentially improving performance.

The entire settings layout with Rows, and intrinsic sizes should be refactored for better performance.

@Leptopoda Leptopoda added package: neon_framework refactoring Something that needs to be refactored labels Sep 25, 2023
@Leptopoda Leptopoda self-assigned this Oct 23, 2023
@Leptopoda Leptopoda removed their assignment Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: neon_framework refactoring Something that needs to be refactored
Projects
None yet
Development

No branches or pull requests

1 participant