Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add recipient info on the right side of the composer #9824

Draft
wants to merge 29 commits into
base: main
Choose a base branch
from

Conversation

GretaD
Copy link
Contributor

@GretaD GretaD commented Jul 10, 2024

fixes #9622

5cba586
Screenshot from 2024-09-10 15-14-49

@GretaD
Copy link
Contributor Author

GretaD commented Jul 22, 2024

Hi @ShGKme we need your vue expertise to decide how to move on here.
Screenshot from 2024-07-22 12-42-31

we would like to find a way how to properly show info on the right pane, that should look more or less like the contact one (see mockup on the initial ticket). Duplicating code is not the right way to go for obvious reasons. Do you have any idea what would be best to do here? This feature has to go in on Thursday.

@ShGKme
Copy link

ShGKme commented Jul 22, 2024

Hi @GretaD

This feature has to go in on Thursday.

Having this, I'd start with duplicating the code. Then you can do it faster. And also see what will be different, what customization or interface will be required.

Then, when it works, we should move it to a library. Either @nextcloud/vue or a new one.

Also, there could be two ways:

  1. Reuse only UI components, but not the login with VCard queries
  2. Reuse everything, like NcTeam* components do in @nextcloud/vue

I'd go with the second one. Not sure this component could be needed as a pure UI component.

@ChristophWurst
Copy link
Member

The raw search query that works

<?xml version="1.0"?>
<x4:addressbook-query xmlns:x4="urn:ietf:params:xml:ns:carddav">
  <x0:prop xmlns:x0="DAV:">
    <x0:getcontenttype/>
    <x0:getetag/>
    <x0:resourcetype/>
    <x0:displayname/>
    <x0:owner/>
    <x0:resourcetype/>
    <x0:sync-token/>
    <x0:current-user-privilege-set/>
    <x0:getcontenttype/>
    <x0:getetag/>
    <x0:resourcetype/>
    <x4:address-data/>
  </x0:prop>
  <x4:filter test="allof">
    <x4:prop-filter name="EMAIL">
      <x1:text-match xmlns:x1="urn:ietf:params:xml:ns:carddav">[email protected]</x1:text-match>
    </x4:prop-filter>
  </x4:filter>
</x4:addressbook-query>

@GretaD GretaD force-pushed the enhanc/recipient-info-composer branch from 41e2077 to 8673d84 Compare August 21, 2024 13:51
@GretaD GretaD force-pushed the enhanc/recipient-info-composer branch from 9d09ecc to 515402f Compare September 10, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recipient info next to mail composer
4 participants