Fix: use message bodies for thread summary #8885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristophWurst
approved these changes
Sep 26, 2023
|
@hamza221 is there any noticeable performance impact for the new roundtrip or the larger text fed into the LLM? |
The thread I tested with for both is not that long, so I can't tell. something I'm afraid of though is openAi's prompt length limitation |
Signed-off-by: hamza221 <[email protected]>
hamza221
force-pushed
the
fix/use-message-body-for-thread-summary
branch
from
b2befbf
to
28ab9ca
Compare
ChristophWurst
approved these changes
Oct 27, 2023
|
/backport to stable3.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Oversight of #8653.
Thread summaries have to be generated from the full body, not just the preview text.