-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Smart replies for mail #8863
Smart replies for mail #8863
Conversation
a4a0ffa
to
abbe9c1
Compare
What's missing for a MVP? |
I'm still not confident about the method of detecting Personal vs non personal emails, aside from that, nothing ig |
Is there anything to consider while testing? I dont't get any reply suggestions. Tried simple mails like in your screenshot. |
If you're getting 200 that means they're getting flagged as generated mails, for some reason. Can you please add a breakpoint and check if its because of |
I started getting this bug, I would say a way around it would be to prompt the LLM twice, once for each reply, what do you think @ChristophWurst ? edit/further explanation: I don't think we can trust it to give us a reply in that format every time |
IMO we can fine-tune the prompts as we test the feature. E.g. I tried |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like with thread summaries we should offer a way to turn this feature off by admins
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested against chatgpt3.5 & works
The suggestions are OK, some are a bit absurd. But that's fine, we can improve the prompt 👍
ff88183
to
ac6b6c2
Compare
|
Signed-off-by: hamza221 <[email protected]> Signed-off-by: hamza mahjoubi <[email protected]>
884a5b4
to
b8e09a2
Compare
Fixes #8505
For now at least one prompt is executed for every opened message