fix(snooze): Add cleanup orphan db entries #8765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristophWurst
approved these changes
Aug 17, 2023
lib/Db/MessageSnoozeMapper.php
Outdated
| $deleteQb->delete($this->getTableName()) | ||
| ->where($deleteQb->expr()->lt( | ||
| 'snoozed_until', | ||
| $deleteQb->createNamedParameter(($this->time->getTime() - 2592000), IQueryBuilder::PARAM_INT), |
There was a problem hiding this comment.
Suggested change
| $deleteQb->createNamedParameter(($this->time->getTime() - 2592000), IQueryBuilder::PARAM_INT), | |
| $deleteQb->createNamedParameter(($this->time->getTime() - (30*7*24*3600)), IQueryBuilder::PARAM_INT), |
for readability and the de-optimization won't hurt
There was a problem hiding this comment.
✅ Removed the 7*, otherwise we would wait 7 months ;)
Signed-off-by: Johannes Merkel <[email protected]>
JohannesGGE
force-pushed
the
fix/8763/add-clenup-for-snooze
branch
from
62e9027
to
bd184dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #8763
Adds a cleanup call to delete all db entries in the snooze table that should have been unsnoozed 30d ago. We assume that these messages no longer exist in the snoozed mailbox.