Fix preview text #8760
Merged
Fix preview text #8760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checking for textBody first might cause #8323 and
|
That's because the sender's client sends a very poor quality text version of the HTML email, right? |
|
Yes here is problematic example from gmail |
|
Failing test looks related to #8694 @JohannesGGE |
|
Fixed it in #8759 |
miaulalala
reviewed
Aug 18, 2023
| @@ -32,7 +32,7 @@ | |||
| "christophwurst/kitinerary-sys": "^0.2.1", | |||
| "ezyang/htmlpurifier": "4.16.0", | |||
| "gravatarphp/gravatar": "dev-master#6b9f6a45477ce48285738d9d0c3f0dbf97abe263", | |||
| "html2text/html2text": "^4.3.1", | |||
| "hamza221/html2text": "^1.0", | |||
There was a problem hiding this comment.
Did you have to fork your own version? 🙀
There was a problem hiding this comment.
yeah, I have a Pr open since march, I think it's about time to give up
mtibben/html2text#116
hamza221
force-pushed
the
fix/preview-text
branch
from
f1d7729
to
f6fb3cb
Compare
Signed-off-by: hamza221 <[email protected]>
hamza221
force-pushed
the
fix/preview-text
branch
from
f6fb3cb
to
8e0a970
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #8222
fixes #8323
bugs fixed
[Text](https://example.com)are now simply => Text