fix: Junk/NotJunk flags

[SebastianKrupinski]

Issue

Junk and NotJunk flags where not being set due to a invalid comparison. UI was sending "$junk" but it was being compared to "junk".

Allowed flags was also missing "notjunk"

[ChristophWurst]

How do we test this?

Found #5370 to change junk to $junk

[ChristophWurst]

mail/src/store/actions.js

Line 991 in 1d5e5b4

flag: '$notjunk',

,

mail/src/store/actions.js

Lines 1011 to 1021 in 1d5e5b4

	// Revert change
	commit('flagEnvelope', {
	envelope,
	flag: '$junk',
	value: oldState,
	})
	commit('flagEnvelope', {
	envelope,
	flag: '$notjunk',
	value: !oldState,
	})

and similar stay?

[SebastianKrupinski]

Yes, The UI handles the "$junk" but the backend compares the it as "junk", so in the UI they can all stay as "$junk" but need to have the $ sign stripped of when sent to the backend. The second image of allowed flags is comparison table, the first image is how they are compared/found.

[ChristophWurst]

Can you point me to the code that strips the $?

[SebastianKrupinski]

How do we test this?

The best way to test is to insert a break point in the OCA\Mail\Service\MailManager::filterFlags() function. That way you can see the values for the table and flag.

Found #5370 to change junk to $junk

This correctly added the front end logic,

commit('flagEnvelope', {
	envelope,
	flag: 'junk',
	flag: '$junk',
	value: !oldState,
})
commit('flagEnvelope', {
	envelope,
	flag: '$notjunk',
	value: !oldState,
})

But incorrectly changed the back end logic,

setEnvelopeFlag(envelope.databaseId, '$junk', !oldState).catch((e) => {