Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(contactsintegration): Limit number of search results #10321

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

ChristophWurst
Copy link
Member

Searching with few characters in large address books or system address books can yield lots of results. This can exhaust the memory and a user likely will search more specifically anyway.

Fixes Allowed memory size of 1073741824 bytes exhausted (tried to allocate 4096 bytes) at /var/www/html/nextcloud/apps/dav/lib/CardDAV/CardDavBackend.php

@ChristophWurst
Copy link
Member Author

/backport to stable4.0

@ChristophWurst
Copy link
Member Author

/backport to stable3.8

@ChristophWurst
Copy link
Member Author

/backport to stable3.7

Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ChristophWurst ChristophWurst merged commit 55259e1 into main Nov 5, 2024
36 of 37 checks passed
@ChristophWurst ChristophWurst deleted the fix/contactsintegration/limit-search-results branch November 5, 2024 14:10
Copy link

backportbot bot commented Nov 5, 2024

The backport to stable3.8 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable3.8
git pull origin stable3.8

# Create the new backport branch
git checkout -b backport/10321/stable3.8

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick b02921e5

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/10321/stable3.8

Error: Failed to clone repository: Failed to checkout branches: fatal: ambiguous argument 'origin/stable3.8': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git [...] -- [...]'


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants