Skip to content

Media View in SwiftUI #2685

Media View in SwiftUI

Media View in SwiftUI #2685

Triggered via pull request October 31, 2023 08:30
Status Success
Total duration 1m 7s
Artifacts
This run and associated checks have been archived and are scheduled for deletion. Learn more about checks retention

lint.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

10 warnings
Lint: Brand/Intro/NCIntroCollectionViewCell.swift#L35
Unneeded Overridden Functions Violation: Remove overridden functions that don't do anything except call their super (unneeded_override)
Lint: iOSClient/Account Request/NCAccountRequest.swift#L80
Unneeded Overridden Functions Violation: Remove overridden functions that don't do anything except call their super (unneeded_override)
Lint: iOSClient/Rename file/NCRenameFile.swift#L129
Unneeded Overridden Functions Violation: Remove overridden functions that don't do anything except call their super (unneeded_override)
Lint: iOSClient/Account Request/NCShareAccounts.swift#L61
Unneeded Overridden Functions Violation: Remove overridden functions that don't do anything except call their super (unneeded_override)
Lint: iOSClient/Notification/NCNotification.swift#L363
Unneeded Overridden Functions Violation: Remove overridden functions that don't do anything except call their super (unneeded_override)
Lint: iOSClient/Media/NCMediaRow.swift#L27
Redundant Discardable Let Violation: Prefer `_ = foo()` over `let _ = foo()` when discarding a result from a function (redundant_discardable_let)
Lint: iOSClient/Media/NCMediaScrollView.swift#L26
Redundant Discardable Let Violation: Prefer `_ = foo()` over `let _ = foo()` when discarding a result from a function (redundant_discardable_let)
Lint: iOSClient/Media/NCMediaScrollView.swift#L74
Todo Violation: TODOs should be resolved (3. Here we load old media (hap...) (todo)
Lint: iOSClient/Media/NCMediaScrollView.swift#L99
Todo Violation: TODOs should be resolved (Maybe .contentMargins() will r...) (todo)
Lint: iOSClient/Media/NCMediaViewModel.swift#L12
Comment Spacing Violation: Prefer at least one space after slashes for comments (comment_spacing)