Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(BackgroundJob): Set expire job intervals to 30 minutes #3323

Closed
wants to merge 1 commit into from

Conversation

@provokateurin provokateurin added the 3. to review Items that need to be reviewed label Oct 7, 2024
@provokateurin provokateurin added this to the Nextcloud 31 milestone Oct 7, 2024
@provokateurin
Copy link
Member Author

/backport to stable30

@provokateurin
Copy link
Member Author

/backport to stable29

@provokateurin
Copy link
Member Author

/backport to stable28

@provokateurin provokateurin force-pushed the fix/backgroundjob/expire-interval branch from 429a51d to 4f743f4 Compare October 7, 2024 06:07
@come-nc
Copy link
Contributor

come-nc commented Oct 7, 2024

Why not align server instead? Or why align at all?

30minutes seems really often for most setups.
If this is because of users setting expiration to less that 1hour, maybe set a shorter interval only in this edge case?

@provokateurin
Copy link
Member Author

Why not align server instead?

Could also do that, to me aligning Groupfolders feels more natural because server is kind of a source of truth (especially given the fact that there is no explanation for any of the intervals anywhere).

Or why align at all?

Because it is easier for admins if all trash/versions expiry jobs have the same interval. This came up in a recent support case as you can see in the files team chat messages from this morning.

30minutes seems really often for most setups.

Agreed, but I don't know the reasoning for any of these intervals as they were never changed after the initial implementation.

If this is because of users setting expiration to less that 1hour, maybe set a shorter interval only in this edge case?

But this doesn't make sense either, then it should be the lowest possible interval to ensure the files are deleted ASAP.

I'm not sure if there is anyone who can actually shed some light onto the situation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Items that need to be reviewed backport-request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants