Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(versions): Handle missing versions folder #3183

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

provokateurin
Copy link
Member

The catch references an potentially uninitialized variable and thus will fail if executed.

@provokateurin provokateurin added bug 3. to review Items that need to be reviewed labels Sep 9, 2024
@provokateurin
Copy link
Member Author

/backport to stable30

@provokateurin
Copy link
Member Author

/backport to stable29

@provokateurin
Copy link
Member Author

/backport to stable28

lib/Versions/VersionsBackend.php Show resolved Hide resolved
@provokateurin provokateurin merged commit cca16eb into master Sep 9, 2024
44 checks passed
@provokateurin provokateurin deleted the fix/versions/missing-folder branch September 9, 2024 13:59
Copy link

backportbot bot commented Sep 9, 2024

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b backport/3183/stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick c61adfcb

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/3183/stable28

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@provokateurin
Copy link
Member Author

The method didn't exist back in stable28 yet, so backport failure is not a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Items that need to be reviewed backport-request bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants