Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: folder icon #3098

Merged
merged 1 commit into from
Aug 7, 2024
Merged

fix: folder icon #3098

merged 1 commit into from
Aug 7, 2024

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Aug 7, 2024 •
edited
Loading

image

Before

image

@skjnldsv skjnldsv added bug 3. to review Items that need to be reviewed design Items related to the web UI (layout, design, etc.) labels Aug 7, 2024
@skjnldsv skjnldsv self-assigned this Aug 7, 2024
AndyScherzinger
AndyScherzinger approved these changes Aug 7, 2024
View reviewed changes
Copy link
Member

@AndyScherzinger AndyScherzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but lacks SVG height/width which is an issue for Safari browsers from wehat I understood from nickvergessen or at least some iOS devices (and their Safari)

@skjnldsv
fix: folder icon
b2c13f3 
Signed-off-by: skjnldsv <[email protected]>
@skjnldsv
Copy link
Member Author

skjnldsv commented Aug 7, 2024

LGTM but lacks SVG height/width which is an issue for Safari browsers from wehat I understood from nickvergessen or at least some iOS devices (and their Safari)

Adjusted! 👍
Thanks 🙇

jancborchardt
jancborchardt approved these changes Aug 7, 2024
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, nice! :)

@skjnldsv skjnldsv merged commit 5c4a109 into master Aug 7, 2024
41 of 44 checks passed
@skjnldsv skjnldsv deleted the fix/icon branch August 7, 2024 15:09
@skjnldsv skjnldsv added 4. to release Items that are ready for releasing and removed 3. to review Items that need to be reviewed labels Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@jancborchardt jancborchardt jancborchardt approved these changes

@susnux susnux Awaiting requested review from susnux

Assignees

@skjnldsv skjnldsv

Labels
4. to release Items that are ready for releasing bug design Items related to the web UI (layout, design, etc.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skjnldsv @jancborchardt @AndyScherzinger