don't error if we can't find a trashbin item for a file when looking … #2813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@icewind1991 Is this related to #2794 ? |
|
Wasn't aware of that issue, butt should resolve it yes. Haven't locally reproduced the issue |
come-nc
reviewed
Feb 15, 2024
icewind1991
force-pushed
the
acl-no-trash-item
branch
from
b2540e4
to
dc0bbee
Compare
come-nc
approved these changes
May 27, 2024
…for relevant acl paths Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
icewind1991
force-pushed
the
acl-no-trash-item
branch
from
dc0bbee
to
777bbe4
Compare
|
Can we backport this? |
|
/backport to stable29 |
|
/backport to stable28 |
|
@icewind1991 You merged with red CI and tests are not compatible 😢 |
Already fixed at #3043 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…for relevant acl paths