Feat custom propagator #2440
Closed
Feat custom propagator #2440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbrousse-recia
force-pushed
the
feat_propagator
branch
3 times, most recently
from
8cac209
to
6cda676
Compare
Signed-off-by: gbrousse-recia <[email protected]>
Signed-off-by: gbrousse-recia <[email protected]>
gbrousse-recia
force-pushed
the
feat_propagator
branch
from
6cda676
to
b82c65b
Compare
|
Thanks for your pull request 👍 Our usual workflow is to submit a change to branch master first and back port to stable (the latter is done by a bot). |
kesselb
added
bug
2. developing
|
Thanks a lot @gbrousse-recia this looks promising, but as @kesselb asked, could you please open a pull request for this towards the master branch? |
|
@gbrousse-recia Do you mind if I cherry pick this and open a new PR to the master branch? |
@tacruc, Yes, no problem, if you think it is revelant. |
Closed
|
closing in favor of #2533, also 25 is EOL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A custom Propagator to fix files updates propagation in nested groupfolders.
Based on branch
stable25.Tested on Nextcloud 25.0.6.
Related Issue
maybe #652 and #1787
Motivation and Context
We had synchronization issues between the server and the client when the files were in nested groupfolders. After some research, we noticed that the propagation was not done correctly (groupfolders etags unchanged in the filecache table).