Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove API v2 #2351

Merged
merged 1 commit into from
Oct 14, 2024
Merged

chore: remove API v2 #2351

merged 1 commit into from
Oct 14, 2024

Conversation

Chartman123
Copy link
Collaborator

Signed-off-by: Christian Hartmann [email protected]

@Chartman123 Chartman123 added 3. to review Waiting for reviews technical debt Technical issue labels Oct 5, 2024
@Chartman123 Chartman123 added this to the 5.0 milestone Oct 5, 2024
@Chartman123 Chartman123 requested review from Koc and susnux October 5, 2024 10:16
@Chartman123 Chartman123 linked an issue Oct 5, 2024 that may be closed by this pull request
Remove deprecated endpoints in API #2348
Closed
@Chartman123 Chartman123 added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Oct 5, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 5, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (main@cc5eadc). Learn more about missing BASE report.
Report is 4 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2351   +/-   ##
=======================================
  Coverage        ?   43.16%           
  Complexity      ?      850           
=======================================
  Files           ?       72           
  Lines           ?     3160           
  Branches        ?        0           
=======================================
  Hits            ?     1364           
  Misses          ?     1796           
  Partials        ?        0

@Chartman123 Chartman123 added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Oct 5, 2024
@Chartman123 Chartman123 mentioned this pull request Oct 5, 2024
Open
@Chartman123
chore: remove API v2
80fa593 
Signed-off-by: Christian Hartmann <[email protected]>
susnux
susnux approved these changes Oct 14, 2024
View reviewed changes
Copy link
Collaborator

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm afterwards we can move to annotations :)

@Chartman123 Chartman123 merged commit 15d0b93 into main Oct 14, 2024
50 checks passed
@Chartman123 Chartman123 deleted the chore/remove-api-v2 branch October 14, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@Koc Koc Awaiting requested review from Koc

Assignees
No one assigned
Labels
3. to review Waiting for reviews technical debt Technical issue
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.

Remove deprecated endpoints in API
2 participants
@Chartman123 @susnux