fix: DI userId instead of userSession
#2293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
force-pushed
the
fix/activity-manager
branch
from
a7e03d0
to
f59f703
Compare
The `ActivityManager` only needs the user ID so we just can inject the `userId`. Also make sure that it can be null, because the `ActivityManager` is DI in the `FormsService` and the `FormsService` is used also for public forms where no user is logged in. Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
fix/activity-manager
branch
from
f59f703
to
0f40230
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2293 +/- ##
=======================================
Coverage ? 45.03%
Complexity ? 814
=======================================
Files ? 68
Lines ? 3073
Branches ? 0
=======================================
Hits ? 1384
Misses ? 1689
Partials ? 0 |
|
Config service has a similar issue, didn't check open PRs before sending #2294 |
Signed-off-by: Ferdinand Thiessen <[email protected]>
|
Fix is included now |
Chartman123
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ActivityManageronly needs the user ID so we just can inject theuserId. Also make sure that it can be null, because theActivityManageris DI in theFormsServiceand theFormsServiceis used also for public forms where no user is logged in.