Allow sharees to see results | Implement PERMISSION_RESULTS
#1461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
added
enhancement
susnux
force-pushed
the
feat/share-results
branch
14 times, most recently
from
206085f
to
6ad7f27
Compare
susnux
changed the title
PERMISSION_RESULTS
susnux
force-pushed
the
feat/share-results
branch
7 times, most recently
from
fdba674
to
1fcfbee
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1461 +/- ##
============================================
+ Coverage 35.47% 38.91% +3.43%
- Complexity 532 556 +24
============================================
Files 52 53 +1
Lines 2224 2295 +71
============================================
+ Hits 789 893 +104
+ Misses 1435 1402 -33 |
susnux
force-pushed
the
feat/share-results
branch
2 times, most recently
from
dbf32d6
to
e8cad3b
Compare
susnux
changed the title
PERMISSION_RESULTSPERMISSION_RESULTS
|
On a shared form with the results permission the TopBar shows the "Share" button on first load. Clicking it does nothing and the button disappears: |
susnux
force-pushed
the
feat/share-results
branch
2 times, most recently
from
883b241
to
703f2a7
Compare
This was due to wrong "share permissions" on the frontend, fixed that |
Chartman123
reviewed
Jan 25, 2023
Chartman123
reviewed
Jan 25, 2023
susnux
force-pushed
the
feat/share-results
branch
5 times, most recently
from
872d099
to
7cf945c
Compare
|
I resolved the comments and added an additional integration test for updating share permissions. |
jotoeri
reviewed
Jan 29, 2023
There was a problem hiding this comment.
Just one small doc remaining, code should be ok.
- But let's first get Fix insert #1465 merged and released. Then we can adapt the API calmly afterwards.
susnux
force-pushed
the
feat/share-results
branch
2 times, most recently
from
f6a347f
to
ae2d903
Compare
Fixed that :) |
jotoeri
approved these changes
Jan 29, 2023
susnux
added
4. to release
Allow users with `results` permission to query and export results Signed-off-by: Ferdinand Thiessen <[email protected]>
* Add unit tests in `FormsService` and `ShareApiControllerTest` * Add permissions to share API documentation Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
Check permission on frontend to show delete buttons Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
feat/share-results
branch
from
ae2d903
to
a032c3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I currently really need the ability to share responses / have multiple users to be able to see the results of a form.
So this implements this feature by adding the available but currently unused permissions to shares and allowing users with permission
resultsto see the submissions.Screenshot
Not much visually added except for the permission checkbox (later an other checkbox for the
editpermission could be added):Todo
ShareApiControllerApiControllerFormsService