Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(developer): Mention PHP 8.4 support #12292

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+62 −2
Open

feat(developer): Mention PHP 8.4 support #12292

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 33 additions & 2 deletions developer_manual/app_publishing_maintenance/app_upgrade_guide/upgrade_to_30.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ In this release support for PHP 8.0 was removed. Follow the steps below to make
.. code-block:: xml

<dependencies>
<php min-version="8.1" max-version="8.3" />
<php min-version="8.1" max-version="8.4" />
<nextcloud min-version="27" max-version="30" />
</dependencies>

Expand All @@ -145,12 +145,43 @@ In this release support for PHP 8.0 was removed. Follow the steps below to make

{
"require": {
"php": ">=8.1 <=8.3"
"php": ">=8.1 <=8.4"
}
}

3. If you have :ref:`continuous integration <app-ci>` set up, remove PHP 8.0 from the matrices of tests and linters.

Support for PHP 8.4 added
^^^^^^^^^^^^^^^^^^^^^^^^^

.. versionadded:: 30.0.2

In this release support for PHP 8.4 was added. Follow the steps below to make your app compatible.

1. If ``appinfo/info.xml`` has a dependency specification for PHP, increase the ``max-version`` to 8.4.

.. code-block:: xml

<dependencies>
<php min-version="8.1" max-version="8.4" />
<nextcloud min-version="26" max-version="28" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<nextcloud min-version="26" max-version="28" />
<nextcloud min-version="26" max-version="30" />

Makes no sense to support 8.4 but not 30.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, was copy pasta from adding 8.3 and seems I didnt replace all.

Suggested change
<nextcloud min-version="26" max-version="28" />
<nextcloud min-version="28" max-version="30" />

</dependencies>


2. If your app has a ``composer.json`` and the file contains the PHP restrictions from ``info.xml``, adjust it as well.

.. code-block:: json

{
"require": {
"php": ">=8.1 <=8.4"
}
}

3. If you have :ref:`continuous integration <app-ci>` set up, extend your test matrix with PHP 8.4 tests and linters.

Information about code changes can be found on `php.net <https://www.php.net/migration84>`__ and `stitcher.io <https://stitcher.io/blog/new-in-php-84>`__.

Added APIs
^^^^^^^^^^

Expand Down
29 changes: 29 additions & 0 deletions developer_manual/app_publishing_maintenance/app_upgrade_guide/upgrade_to_31.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,35 @@ Removed APIs
Back-end changes
----------------

Support for PHP 8.4 added
^^^^^^^^^^^^^^^^^^^^^^^^^

In this release support for PHP 8.4 was added. Follow the steps below to make your app compatible.

1. If ``appinfo/info.xml`` has a dependency specification for PHP, increase the ``max-version`` to 8.4.

.. code-block:: xml

<dependencies>
<php min-version="8.1" max-version="8.4" />
<nextcloud min-version="26" max-version="28" />
Copy link
Contributor

@come-nc come-nc Oct 17, 2024 •
edited by nickvergessen
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<nextcloud min-version="26" max-version="28" />
<nextcloud min-version="29" max-version="31" />

</dependencies>


2. If your app has a ``composer.json`` and the file contains the PHP restrictions from ``info.xml``, adjust it as well.

.. code-block:: json

{
"require": {
"php": ">=8.1 <=8.4"
}
}

3. If you have :ref:`continuous integration <app-ci>` set up, extend your test matrix with PHP 8.4 tests and linters.

Information about code changes can be found on `php.net <https://www.php.net/migration84>`__ and `stitcher.io <https://stitcher.io/blog/new-in-php-84>`__.

Added APIs
^^^^^^^^^^

Expand Down