Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dev): Use non-ambigous array syntax in OpenAPI tutorial #12231

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

provokateurin
Copy link
Member

☑️ Resolves

nextcloud/openapi-extractor#33
nextcloud/openapi-extractor#168

This fix is fully backwards compatible, so we can already advertise it.

@provokateurin
Copy link
Member Author

/backport to stable30

@provokateurin
Copy link
Member Author

/backport to stable29

@provokateurin
Copy link
Member Author

/backport to stable28

Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

list<empty> and array<empty> are the same thing, but okay.

@nickvergessen
Copy link
Member

list and array are the same thing, but okay.

Only in PHP, it's problematic in JSON and therefore spills over to clients.
https://3v4l.org/42qO0 that is exactly where we are coming from

@come-nc
Copy link
Contributor

come-nc commented Sep 26, 2024

list and array are the same thing, but okay.

Only in PHP, it's problematic in JSON and therefore spills over to clients. https://3v4l.org/42qO0 that is exactly where we are coming from

I did not write list and array but list<empty> and array<empty>. Both are [].

@provokateurin
Copy link
Member Author

It's a bit easier to handle it this way though, then the checks for array<TYPE> are simpler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants