Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Documentation for Android Deep Link Handling #12075

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

alperozturk96
Copy link

@alperozturk96 alperozturk96 commented Jul 30, 2024

☑️ Resolves

This pull request includes documentation for handling deep links in Android applications, specifically addressing the requirements and configurations for Android 12 and above.

🖼️ Screenshots

Screenshot 2024-07-30 at 12 32 26

@alperozturk96 alperozturk96 changed the title Add documentation for Android Deep Link Handling Add Documentation for Android Deep Link Handling Jul 30, 2024
@alperozturk96 alperozturk96 force-pushed the add-deep-link-handling-android branch from f192dba to 2e330ae Compare July 30, 2024 10:13
@alperozturk96 alperozturk96 force-pushed the add-deep-link-handling-android branch from 046ea76 to 15186a8 Compare July 30, 2024 10:21
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • This page is not included anywhere
  • Heading lines do not match the heading text length
  • Heading structure makes no sense. There should be a page title, then sections, etc. Right now there are four sections with =

Comment on lines 40 to 41
Replace APP_SHA256_FINGERPRINT with the SHA-256 fingerprint of your app’s
signing certificate.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, this is only applicable to branded apps, right?

This either needs a big caveat at the top of the chapter or maybe it shouldn't be included here since it's not applicable to community users... so maybe it only belongs in the customer docs in https://portal.nextcloud.com somewhere?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alperozturk96 this also works for our official app, right?
So maybe add the sha256 of our app here.
And as Josh suggested, add a portal entry how this needs to be changed for branded apps.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tobiasKaminsky How can I add portal entry?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joshtrichards
Copy link
Member

This page is not included anywhere

The globbing recently added in #11691 should pick it up. :-)

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good structure-wise. Can't say much about the content :)

alperozturk96 and others added 9 commits August 1, 2024 09:17
Signed-off-by: alperozturk <[email protected]>
Co-authored-by: Josh <[email protected]>
Signed-off-by: Alper Öztürk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Co-authored-by: Josh <[email protected]>
Signed-off-by: Alper Öztürk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Co-authored-by: Josh <[email protected]>
Signed-off-by: Alper Öztürk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Co-authored-by: Josh <[email protected]>
Signed-off-by: Alper Öztürk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Co-authored-by: Josh <[email protected]>
Signed-off-by: Alper Öztürk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
@joshtrichards
Copy link
Member

Is this intended as an alternative approach to nextcloud/server#44665?

@alperozturk96
Copy link
Author

alperozturk96 commented Aug 2, 2024

Is this intended as an alternative approach to nextcloud/server#44665?

No, that PR is only functional for us. If a user wants to use it with a different server name, it will not work on Android 12 or above.

For more details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants