Update Apache LimitRequestBody for >1 GiB v2 chunking too #11295
Conversation
The recent addition clarified Apache's new behavior and and this setting's impact on non-chunking clients. With the recent v2 chunking client implementations, the maxChunkSize can be as high as 5 GiB by default (e.g. see nextcloud/desktop#6222). This expands the language to note impact for chunking clients too and clarifies the available options. Signed-off-by: Josh Richards <[email protected]>
admin_manual/configuration_files/big_file_upload_configuration.rst
Outdated
Show resolved
Hide resolved
Signed-off-by: Josh Richards <[email protected]>
joshtrichards
changed the title
| @@ -65,7 +65,7 @@ for how to configure those values correctly: | |||
|
|
|||
| Apache | |||
| ^^^^^^ | |||
| * `LimitRequestBody <https://httpd.apache.org/docs/current/en/mod/core.html#limitrequestbody>`_ (In Apache HTTP Server <=2.4.53 this defaulted to unlimited, but now defaults to 1 GiB. The new default limits uploads from non-chunking clients to 1 GiB. If this is a concern in your environment, override the new default by either manually setting it to ``0`` or to a value similar to that used for your local environment's PHP ``upload_max_filesize / post_max_size / memory_limit`` parameters.) | |||
| * `LimitRequestBody <https://httpd.apache.org/docs/current/en/mod/core.html#limitrequestbody>`_ (In Apache HTTP Server <=2.4.53 this defaulted to unlimited, but now defaults to 1 GiB. The new default limits uploads from non-chunking clients to 1 GiB and also limits the maximum chunk size for recent versions of the official Nextcloud clients to 1 GiB even though they may require up to 5 GiB. This will break uploads >1 GiB under various circumstances. Our recommendation is to set this Apache parameter to 5 GiB or to the old default behavior of unlimited. Also make sure to review your local environment's PHP ``upload_max_filesize / post_max_size / memory_limit`` parameters to make sure they are at least the same size. For chunking capable clients that support manual configuration, as an alternative, the default maximum chunk size can be reduced to 1 GiB, but each client installation will need this parameter to then be manually configured.) | |||
There was a problem hiding this comment.
Are you sure about the chunk size of the desktop client? I think by default maxchunksize is set to 1GB, no? So why should it require up to 5GB?
There was a problem hiding this comment.
It's 5GB today. It was changed in nextcloud/desktop#5939
Context: The desktop client is more aggressive about using a large chunk size (versus our web client). This same behavior is essentially the underlying cause of nextcloud/desktop#4278 too (while many of those people are using CF since that's specifically covering the 100MB CF limit, the same underlying problem applies to body size limits in Apache and Nginx; only the absolute number varies).
Though today - rather than updating the docs - I'm of the opinion we should really fix the mentioned issue in the desktop client. Then the language in this PR can be more about "optimizing upload performance" rather than "fixing broken uploading".
There was a problem hiding this comment.
Though today - rather than updating the docs - I'm of the opinion we should really fix the mentioned issue in the desktop client. Then the language in this PR can be more about "optimizing upload performance" rather than "fixing broken uploading".
Agreed 💯
#10989 clarified Apache's new behavior and this setting's impact on non-chunking clients.
With the recent v2 chunking client implementations, the maxChunkSize can be as high as 5 GiB either by default (e.g. see nextcloud/desktop#6222) or as a result of user configuration.
This expands the language to note impact for chunking clients too and clarifies the available options for clients.
Thanks to @Malex14 for pointing this out! 👍
☑️ Resolves
🖼️ Screenshots