Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable-3.14] Fix adding account and skipping folder configuration crash. #7551

Merged
merged 14 commits into from
Nov 25, 2024
Merged

[stable-3.14] Fix adding account and skipping folder configuration crash. #7551

merged 14 commits into from
Nov 25, 2024

Commits on Nov 22, 2024

  1. Use slotComputeOverallSyncStatus as a slot. 

    - Use qAsConst.

Signed-off-by: Camila Ayres <[email protected]>
    @camilasan @backportbot
    camilasan authored and backportbot[bot] committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    8ba2b1a View commit details
    Browse the repository at this point in the history

  2. Fix warning "Calling C++ methods with 'this' objects different from t… 

    …he one they were retrieved from is broken"

https://doc.qt.io/qt-6/qtqml-documents-structure.html#nativemethodbehavior

Signed-off-by: Camila Ayres <[email protected]>
    @camilasan @backportbot
    camilasan authored and backportbot[bot] committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    c7b7769 View commit details
    Browse the repository at this point in the history

  3. Modernize Account::displayName(). 

    Signed-off-by: Camila Ayres <[email protected]>
    @camilasan @backportbot
    camilasan authored and backportbot[bot] committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    a379a78 View commit details
    Browse the repository at this point in the history

  4. Use slots as slots. 

    Signed-off-by: Camila Ayres <[email protected]>
    @camilasan @backportbot
    camilasan authored and backportbot[bot] committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    1d99881 View commit details
    Browse the repository at this point in the history

  5. Diferentiate between display name and dav display name. 

    Signed-off-by: Camila Ayres <[email protected]>
    @camilasan @backportbot
    camilasan authored and backportbot[bot] committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    9a22c07 View commit details
    Browse the repository at this point in the history

  6. Rename vars: _am => _networkAccessManager, a => newAccountData. 

    Signed-off-by: Camila Ayres <[email protected]>
    @camilasan @backportbot
    camilasan authored and backportbot[bot] committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    ad3f42c View commit details
    Browse the repository at this point in the history

  7. Use saveAccount for adding single account. 

    Signed-off-by: Camila Ayres <[email protected]>
    @camilasan @backportbot
    camilasan authored and backportbot[bot] committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    ffd3270 View commit details
    Browse the repository at this point in the history

  8. Add {} to single line if. 

    Signed-off-by: Camila Ayres <[email protected]>
    @camilasan @backportbot
    camilasan authored and backportbot[bot] committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    5aad0fe View commit details
    Browse the repository at this point in the history

  9. acc => account. 

    Signed-off-by: Camila Ayres <[email protected]>
    @camilasan @backportbot
    camilasan authored and backportbot[bot] committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    6dcb6aa View commit details
    Browse the repository at this point in the history

  10. wiz => owncloudSetupWizard. 

    Signed-off-by: Camila Ayres <[email protected]>
    @camilasan @backportbot
    camilasan authored and backportbot[bot] committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    ad74580 View commit details
    Browse the repository at this point in the history

  11. Call for done() when skipping folder configuration. 

    Signed-off-by: Camila Ayres <[email protected]>
    @camilasan @backportbot
    camilasan authored and backportbot[bot] committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    3e60f63 View commit details
    Browse the repository at this point in the history

  12. Remove check before setting display name. 

    Signed-off-by: Camila Ayres <[email protected]>
    @camilasan @backportbot
    camilasan authored and backportbot[bot] committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    eb76dbd View commit details
    Browse the repository at this point in the history

  13. Fix tests: make sure displayName is not empty. 

    Signed-off-by: Camila Ayres <[email protected]>
    @camilasan @backportbot
    camilasan authored and backportbot[bot] committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    f24f22b View commit details
    Browse the repository at this point in the history

  14. Correct Q_PROPERTY for _davDisplayName. 

    Signed-off-by: Camila Ayres <[email protected]>
    @camilasan @backportbot
    camilasan authored and backportbot[bot] committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    88708da View commit details
    Browse the repository at this point in the history