Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix file tag fetching for files in sync folders that have non-root remote target #7375

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fix file tag fetching for files in sync folders that have non-root remote target #7375

wants to merge 5 commits into from
+44 −19

Commits on Oct 21, 2024

  1. Mark non-const getters in Folder definition as const 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    853b7b8 View commit details
    Browse the repository at this point in the history

  2. Store fetched folder as private member in filedetails 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    de4460f View commit details
    Browse the repository at this point in the history

  3. Simply pass AccountPtr to updateFileTagModel 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    6574625 View commit details
    Browse the repository at this point in the history

  4. Ensure we are checking for tags in correct server path regardless of … 

    …the particular local path

Fixes issues with users who are using remote non-root sync folders

Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    9c5d1e2 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2024

  1. Move setup of server relative path used in FileTagModel into FileDetails 

    This fixes the build breakages in the file tag model tests

Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    eff48c1 View commit details
    Browse the repository at this point in the history