Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a context menu for the sharees search field #7355

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

claucambra
Copy link
Collaborator

Closes #6199

Screenshot 2024-10-18 at 12 03 26

@claucambra claucambra added this to the 3.15.0 milestone Oct 18, 2024
@claucambra claucambra self-assigned this Oct 18, 2024
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-7355-3f34805183fcbe63241ae9cff3ba905a11c0187b-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

Copy link
Collaborator

@mgallien mgallien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does not work so nicely if your platform Qt qml style is also providing a context menu
in such a case, you get a sequence of 2 different context menus which makes it broken from user perspective

@claucambra
Copy link
Collaborator Author

@mgallien argh, I had not thought of that, thanks for bringing it up

are you aware of how we can detect this? I would rather not traverse the scene graph to check...

Copy link

sonarcloud bot commented Nov 18, 2024

@claucambra claucambra modified the milestones: 3.15.0, 3.16.0 Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Context menu for share window
3 participants