-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix update channels #7350
Bugfix update channels #7350
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nitpicks otherwise looks good imo
7d5db8e
to
3eb582c
Compare
/backport to stable-3.14 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when built with BUILD_UPDATER=OFF
, build failed as expected from my inline comment
It should only return the value. Signed-off-by: Camila Ayres <[email protected]>
Signed-off-by: Camila Ayres <[email protected]>
…rprise. Signed-off-by: Camila Ayres <[email protected]>
Maintain stable and enterprise. Signed-off-by: Camila Ayres <[email protected]>
Signed-off-by: Camila Ayres <[email protected]>
…ith subscription. Signed-off-by: Camila Ayres <[email protected]>
… added or removed. To give priority to server susbscriptions and keep listing the right update channels. Signed-off-by: Camila Ayres <[email protected]>
Signed-off-by: Camila Ayres <[email protected]>
Signed-off-by: Camila Ayres <[email protected]>
Only connect signal/slot for update channels listing when BUILD_UPDATER is ON. Signed-off-by: Camila Ayres <[email protected]>
4c06e02
to
9b33cb5
Compare
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
AppImage file: nextcloud-PR-7350-9b33cb5e0dc1cca89eae977d2b5f010c55851fc4-x86_64.AppImage |
I was just hoping to catch the issue of reports about it - like the channel changing without the user interaction.