Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve wordings of confirmation dialog when many files are deleted #7319

Merged
merged 1 commit into from
Oct 16, 2024
Merged

improve wordings of confirmation dialog when many files are deleted #7319

merged 1 commit into from
Oct 16, 2024

Conversation

mgallien
Copy link
Collaborator

No description provided.

@mgallien
Copy link
Collaborator Author

/backport to stable-3.12

@mgallien
Copy link
Collaborator Author

/backport to stable-3.13

@mgallien
Copy link
Collaborator Author

/backport to stable-3.14

@mgallien mgallien force-pushed the bugfix/betterMessageForFilesDeletionDetection branch from 65279fe to 08abced Compare October 16, 2024 07:11
@mgallien mgallien added this to the 3.14.2 milestone Oct 16, 2024
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-7319-08abceda73ff3f515d493c408f76f5aeac9736d9-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 16, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
23 New Code Smells (required ≤ 0)
E Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@mgallien mgallien merged commit ace0278 into master Oct 16, 2024
11 of 15 checks passed
@mgallien mgallien deleted the bugfix/betterMessageForFilesDeletionDetection branch October 16, 2024 07:45
This was referenced Oct 16, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claucambra claucambra claucambra approved these changes

@camilasan camilasan Awaiting requested review from camilasan

@Rello Rello Awaiting requested review from Rello

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.14.2
Development

Successfully merging this pull request may close these issues.
3 participants
@mgallien @nextcloud-desktop-bot @claucambra