Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear error list after displaying it once. #6831

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

camilasan
Copy link
Member

Possible fix for #6448 and #6487.

@camilasan camilasan force-pushed the bugfix/network-notifications branch from 66e8a73 to 0c65513 Compare June 24, 2024 18:02
Copy link
Collaborator

@claucambra claucambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By doing this are we not wiping away ay errors that need actions from users?

I also don't see how this fixes the errors referenced in the PR post; it seems to me we should be more lenient in how we tolerate post-device-wake-up errors in the client, rather than changing how errors are presented

@camilasan camilasan force-pushed the bugfix/network-notifications branch from 0c65513 to 8011c30 Compare June 25, 2024 12:28
@camilasan
Copy link
Member Author

By doing this are we not wiping away ay errors that need actions from users?

I also don't see how this fixes the errors referenced in the PR post; it seems to me we should be more lenient in how we tolerate post-device-wake-up errors in the client, rather than changing how errors are presented

Yes, I am still thinking on how to properly/correctly approach this.

@camilasan camilasan marked this pull request as draft June 25, 2024 12:31
Copy link

sonarcloud bot commented Jun 25, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)
6 New Code Smells (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@camilasan camilasan force-pushed the bugfix/network-notifications branch from 8011c30 to e575561 Compare August 4, 2024 20:20
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-6831-e57556138b75a1e579ea0a79db6cd89ef9286632-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

Copy link

sonarcloud bot commented Aug 4, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
B Maintainability Rating on New Code (required ≥ A)
8 New Code Smells (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants