-
Notifications
You must be signed in to change notification settings - Fork 804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add daily update channel. #6658
Conversation
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
fca12f6
to
a133d1a
Compare
180edbe
to
031319f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely an improvement! :) Love the bullet points, they make things so much more clear. The wording is also way more concise!
I would suggest only a few minor changes
- stable: contains tested versions considered reliable
- beta: contains versions with new features that may not be tested thoroughly
- daily: contains versions created daily only for testing and development
Downgrading versions is not possible immediately: changing from beta to stable means waiting for the new stable version.
As a follow up, I would propose some more changes:
- on the settings page, the channels could be in radio buttons instead of in a dropdown.
- that way we could move the channel info directly onto the settings page
- change the confirmation dialog to show only the "downgrading is not possible" message
- show the confirmation dialog only when changing from daily to beta or beta to stable
What do you think :)
It's a really good idea, why only tests on Linux? How will the enterprise (stable) versions be validated? |
031319f
to
13b0d9e
Compare
|
@camilasan looks great! I would only recommend that it's in a vertical arrangement instead of horizontal :) |
13b0d9e
to
7b05000
Compare
I will address this in #6873 |
- Set update channel options list in slotUpdateInfo. Signed-off-by: Camila Ayres <[email protected]>
Signed-off-by: Camila Ayres <[email protected]>
…channel. - Also makes the explanation more concise. Signed-off-by: Camila Ayres <[email protected]>
Signed-off-by: Camila Ayres <[email protected]>
Signed-off-by: Camila Ayres <[email protected]>
Signed-off-by: Camila Ayres <[email protected]>
Signed-off-by: Camila Ayres <[email protected]>
Signed-off-by: Camila Ayres <[email protected]>
Signed-off-by: Camila Ayres <[email protected]>
Signed-off-by: Camila Ayres <[email protected]>
Signed-off-by: Camila Ayres <[email protected]>
Signed-off-by: Camila Ayres <[email protected]>
Signed-off-by: Camila Ayres <[email protected]>
Signed-off-by: Camila Ayres <[email protected]>
Signed-off-by: Camila Ayres <[email protected]>
Signed-off-by: Camila Ayres <[email protected]>
0b87344
to
4de3107
Compare
AppImage file: nextcloud-PR-6658-4de310738309b8b61c9495674f00966fd968689a-x86_64.AppImage |
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
Client updater: nextcloud/client_updater_server#144
Infrastructure: https://github.com/nextcloud-gmbh/internal-infrastructure/pull/416
Adds the daily and enterprise option to the update url:
channel=daily
Changes the message box test when the user switches update channels:
Test: