Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide password field in share settings when share type does not support passwords #5948

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

claucambra
Copy link
Collaborator

Fixes #5947

Screenshot 2023-08-02 at 18 02 25

@claucambra
Copy link
Collaborator Author

/backport to stable-3.9

@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #5948 (8bda3fd) into master (658e9cd) will increase coverage by 0.11%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5948      +/-   ##
==========================================
+ Coverage   59.97%   60.09%   +0.11%     
==========================================
  Files         145      145              
  Lines       18806    18806              
==========================================
+ Hits        11279    11301      +22     
+ Misses       7527     7505      -22     

see 3 files with indirect coverage changes

@mgallien mgallien force-pushed the bugfix/share-password-entry-display branch from 7c5ee20 to 8bda3fd Compare August 22, 2023 08:11
@sonarcloud
Copy link

sonarcloud bot commented Aug 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.14.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5948-8bda3fdce743278c45ce931fec5aecd3f7ec137a-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien mgallien merged commit e83c2c8 into master Aug 22, 2023
12 checks passed
@mgallien mgallien deleted the bugfix/share-password-entry-display branch August 22, 2023 09:00
@mgallien mgallien added this to the 3.10.0 milestone Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Password protection option is (but shouldn't be) visible for internal shares
3 participants