Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display correct server colour prior to acquiring server capabilities #5946

Merged
merged 5 commits into from
Aug 24, 2023
Merged

Display correct server colour prior to acquiring server capabilities #5946

merged 5 commits into from
Aug 24, 2023

Conversation

claucambra
Copy link
Collaborator

Fixes #5930

@claucambra claucambra self-assigned this Aug 1, 2023
@codecov
Copy link

codecov bot commented Aug 1, 2023 •
edited
Loading

Codecov Report

Merging #5946 (e43e3a2) into master (eec4069) will increase coverage by 0.13%.
The diff coverage is 41.17%.

❗ Current head e43e3a2 differs from pull request most recent head 01cb5d7. Consider uploading reports for the commit 01cb5d7 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5946      +/-   ##
==========================================
+ Coverage   60.09%   60.22%   +0.13%     
==========================================
  Files         145      145              
  Lines       18810    18814       +4     
==========================================
+ Hits        11303    11330      +27     
+ Misses       7507     7484      -23
Files Changed Coverage Δ
src/libsync/account.cpp 43.39% <37.50%> (+0.54%) ⬆️
src/libsync/account.h 42.85% <100.00%> (+2.85%) ⬆️

... and 5 files with indirect coverage changes

@claucambra
Copy link
Collaborator Author

/backport to stable-3.9

allexzander
allexzander suggested changes Aug 22, 2023
View reviewed changes
src/libsync/account.h Outdated Show resolved Hide resolved
src/libsync/account.h Outdated Show resolved Hide resolved
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5946-01cb5d7e222a7b783d2540aa21437825c0c0d1e8-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarcloud
Copy link

sonarcloud bot commented Aug 24, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

30.0% 30.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@claucambra claucambra merged commit daba7a1 into master Aug 24, 2023
8 of 10 checks passed
@claucambra claucambra deleted the bugfix/remember-server-color branch August 24, 2023 02:07
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Aug 24, 2023
Merged
@mgallien mgallien added this to the 3.10.0 milestone Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allexzander allexzander allexzander approved these changes

@mgallien mgallien Awaiting requested review from mgallien

@camilasan camilasan Awaiting requested review from camilasan

Assignees

@claucambra claucambra

Labels
None yet
Projects
None yet
Milestone
3.10.0
Development

Successfully merging this pull request may close these issues.

Tray not themed in offline state
4 participants
@claucambra @nextcloud-desktop-bot @allexzander @mgallien