Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable-3.9] Fix SVG rendering error in SvgImageProvider #5909

Merged
merged 3 commits into from
Jul 21, 2023

Conversation

backportbot-nextcloud[bot]
Copy link

Backport of #5666

@backportbot-nextcloud backportbot-nextcloud bot added this to the 3.9.1 milestone Jul 20, 2023
@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Merging #5909 (1b57b31) into stable-3.9 (470a983) will increase coverage by 0.00%.
The diff coverage is 66.66%.

❗ Current head 1b57b31 differs from pull request most recent head 733bb7c. Consider uploading reports for the commit 733bb7c to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           stable-3.9    #5909   +/-   ##
===========================================
  Coverage       60.45%   60.45%           
===========================================
  Files             145      145           
  Lines           18650    18653    +3     
===========================================
+ Hits            11274    11276    +2     
- Misses           7376     7377    +1     
Impacted Files Coverage Δ
src/libsync/vfs/cfapi/cfapiwrapper.cpp 72.80% <66.66%> (-0.05%) ⬇️

@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5909-733bb7ced09191f2a71f4a5bf31ee07c6be2db4a-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarcloud
Copy link

sonarcloud bot commented Jul 21, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

76.0% 76.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@mgallien mgallien merged commit f59f34d into stable-3.9 Jul 21, 2023
8 of 10 checks passed
@mgallien mgallien deleted the backport/5666/stable-3.9 branch July 21, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants