-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nmc/runwizard_introduction #5870
base: master
Are you sure you want to change the base?
nmc/runwizard_introduction #5870
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a nice change :) CCing @jancborchardt
@AnkurBavisa can you rebase the branch ? |
2c8650e
to
40f0e91
Compare
Yes, done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really nice! great improvement :)
I would suggest that the wording be changed form "Reopen browser" to "Open browser" since it has been made the primary button, and it would be likely be clicked only if the browser hasn't been opened yet. Other than that small change, it looks great! :)
e7ea512
to
25ff592
Compare
25ff592
to
e0ff427
Compare
Signed-off-by: Ankur Bavisa <[email protected]>
e0ff427
to
a1efbef
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5870 +/- ##
=======================================
Coverage 60.24% 60.25%
=======================================
Files 145 145
Lines 18868 18868
=======================================
+ Hits 11367 11368 +1
+ Misses 7501 7500 -1 |
AppImage file: nextcloud-PR-5870-a1efbef19468a736cebba479502b312c739557a5-x86_64.AppImage |
Update run wizard introduction screen UI.
Modified "Copy Link" & "Reopen Browser" with QPushButton to apply stylesheet.
Attached screen shots of UI change & final output[before & After], also attached screenshots of MagentCloud output screen for stylesheet reference.
--NC_Run_Wizard_Intro_After--
--NC_Run_Wizard_Intro_Before--
--NC_UI_Design_After--
--NC_UI_Design_Before--
--MagentCloud reference screen--