Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix residual typos found by codespell #5860

Merged
merged 1 commit into from
Sep 16, 2023
Merged

Fix residual typos found by codespell #5860

merged 1 commit into from
Sep 16, 2023

Conversation

DimitriPapadopoulos
Copy link
Contributor

I have changed a local variable name from:

    for (const auto &activ : activities) {
        const auto json = activ.toObject();

to:

    for (const auto &activity : activities) {
        const auto json = activity.toObject();

@mgallien
Copy link
Collaborator

mgallien commented Jul 5, 2023

@DimitriPapadopoulos thanks 💙

@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Merging #5860 (6cf4dea) into master (e6676ac) will decrease coverage by 0.11%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

❗ Current head 6cf4dea differs from pull request most recent head 09521ed. Consider uploading reports for the commit 09521ed to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5860      +/-   ##
==========================================
- Coverage   60.24%   60.14%   -0.11%     
==========================================
  Files         145      145              
  Lines       18868    18872       +4     
==========================================
- Hits        11367    11350      -17     
- Misses       7501     7522      +21     
Files Changed Coverage Δ
src/libsync/abstractnetworkjob.h 53.84% <ø> (ø)
src/libsync/discoveryphase.cpp 79.05% <ø> (ø)

... and 9 files with indirect coverage changes

@DimitriPapadopoulos
Copy link
Contributor Author

DimitriPapadopoulos commented Aug 22, 2023

The SonarCloud analysis appears to have been broken for quite a long time, and the last error reports don't make any sense or do not seem actionable (such as 1500 new code smells on translation updates).

@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5860-6cf4dea576731005a80232784141c287e498baec-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

Signed-off-by: Dimitri Papadopoulos <[email protected]>
@mgallien mgallien merged commit b5cb8ee into nextcloud:master Sep 16, 2023
7 of 8 checks passed
@DimitriPapadopoulos DimitriPapadopoulos deleted the codespell branch September 16, 2023 19:22
@mgallien mgallien added this to the 3.11.0 milestone Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants