Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to move deleted files to trash instead of permanently deleting them #5698

Merged
merged 2 commits into from
Jul 20, 2023

Conversation

claucambra
Copy link
Collaborator

Closes #3362

Screenshot 2023-05-16 at 13 51 50

@sonarcloud
Copy link

sonarcloud bot commented May 16, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Merging #5698 (f908b7d) into master (bb87813) will decrease coverage by 0.79%.
The diff coverage is 0.00%.

❗ Current head f908b7d differs from pull request most recent head e54d78a. Consider uploading reports for the commit e54d78a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5698      +/-   ##
==========================================
- Coverage   60.05%   59.26%   -0.79%     
==========================================
  Files         145      143       -2     
  Lines       18759    18466     -293     
==========================================
- Hits        11265    10944     -321     
- Misses       7494     7522      +28     
Impacted Files Coverage Δ
src/common/filesystembase.cpp 75.00% <0.00%> (-1.44%) ⬇️

... and 47 files with indirect coverage changes

@claucambra claucambra self-assigned this May 16, 2023
@allexzander
Copy link
Contributor

@claucambra please squash

…ing files to trash, rather than immediate deletion

Signed-off-by: Claudio Cambra <[email protected]>
@claucambra claucambra merged commit b4c9761 into master Jul 20, 2023
7 of 8 checks passed
@claucambra claucambra deleted the feature/trashfiles branch July 20, 2023 16:14
@szaimen
Copy link
Contributor

szaimen commented Jul 20, 2023

🎉🎉🎉🎉🎉

@sonarcloud
Copy link

sonarcloud bot commented Jul 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5698-e54d78ad69e7f81f9e0eeb9279da6384d8707927-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien mgallien added this to the 3.10.0 milestone Sep 7, 2023
joshtrichards added a commit that referenced this pull request Aug 27, 2024
Since #5698 / #3362 this option is no longer restricted to Linux. (It's also now in the GUI too).

Signed-off-by: Josh <[email protected]>
mgallien pushed a commit that referenced this pull request Aug 28, 2024
Since #5698 / #3362 this option is no longer restricted to Linux. (It's also now in the GUI too).

Signed-off-by: Josh <[email protected]>
backportbot bot pushed a commit that referenced this pull request Aug 28, 2024
Since #5698 / #3362 this option is no longer restricted to Linux. (It's also now in the GUI too).

Signed-off-by: Josh <[email protected]>
backportbot bot pushed a commit that referenced this pull request Aug 28, 2024
Since #5698 / #3362 this option is no longer restricted to Linux. (It's also now in the GUI too).

Signed-off-by: Josh <[email protected]>
mgallien pushed a commit that referenced this pull request Aug 28, 2024
Since #5698 / #3362 this option is no longer restricted to Linux. (It's also now in the GUI too).

Signed-off-by: Josh <[email protected]>
claucambra pushed a commit that referenced this pull request Sep 24, 2024
Since #5698 / #3362 this option is no longer restricted to Linux. (It's also now in the GUI too).

Signed-off-by: Josh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for moveToTrash option in nextcloud client for Microsoft windows OS and MacOS
5 participants