-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure errors are displayed as first entries in tray window activity list, add testing for SortedActivityListModel #5408
Conversation
/backport to stable-3.7 |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5408 +/- ##
==========================================
+ Coverage 60.05% 60.08% +0.02%
==========================================
Files 145 145
Lines 18762 18762
==========================================
+ Hits 11268 11273 +5
+ Misses 7494 7489 -5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is missing automated tests
5923cff
to
ed56fd1
Compare
Took a lot of changes to not duplicate masses of code, but the sort order is now fully tested (and the sortedactivitylistmodel in general) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy
found issue(s) with the introduced code (1/1)
SonarCloud Quality Gate failed. |
f1a01de
to
3f3c9ed
Compare
3f3c9ed
to
6b4bf71
Compare
AppImage file: nextcloud-PR-5408-6b4bf71a5ee68cff7bdc1bc5842407f8bc1c750d-x86_64.AppImage |
Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
… method in ActivityTestUtils Signed-off-by: Claudio Cambra <[email protected]>
…ivitylistmodeltestutils Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
…ated when the sourcemodel does Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
…ities to be displayed in activitylistmodel Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
6b4bf71
to
74bdbb4
Compare
No clang-tidy warnings found so I assume my comments were addressed
SonarCloud Quality Gate failed. 0 Bugs 94.4% Coverage Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
The backport to stable-3.7 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable-3.7
git pull origin stable-3.7
# Create the new backport branch
git checkout -b fix/foo-stable-3.7
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable-3.7 More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
AppImage file: nextcloud-PR-5408-74bdbb4aa13bf92bff05e82b3a4605d6a224f9f7-x86_64.AppImage |
At the moment they are often pushed way down the list below less important entries such as notifications due to their activity type
With this PR we ensure they are first on the list
With this PR:
Master:
Screen.Recording.2023-02-06.at.15.25.39.mov