-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Quit from Initial Setup #2974
Conversation
I went ahead and incorporated the code from #2959. FWIW the code could probably be generalized using the QWinTaskbarButton Class to show and hide the taskbar icon on Windows similarly to how the code currently works on macOS. I don't have a Windows install set up currently, though, so I wouldn't be able to implement and test it in the immediate future. I don't know what's involved in showing and hiding the dock icon on Linus. |
I implemented changes so that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, much more tidy and focused. Much less confusing to review, thanks!
Will probably need grooming the history in that branch though, other than that it looks like it's getting there.
Signed-off-by: Elsie Hupp <[email protected]>
d3ea463
to
3b0f663
Compare
AppImage file: Nextcloud-PR-2974-3b0f663612d0d932f52c04fc447c62344e7e62be-x86_64.AppImage |
Fixes #2969.
I've tested this on macOS but not on Linux or Windows.
I'm thinking of adding my code from #2959 that shows and hides the dock icon, as well. (I'll put it in a separate commit so it's easier to test.)