Skip to content

Commit

Permalink
Call for done() when skipping folder configuration.
Browse files Browse the repository at this point in the history
Signed-off-by: Camila Ayres <[email protected]>
  • Loading branch information
camilasan committed Nov 5, 2024
1 parent 11de315 commit 0b58b47
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions src/gui/owncloudsetupwizard.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -699,7 +699,7 @@ void OwncloudSetupWizard::slotAssistantFinished(int result)
}

// notify others.
_ocWizard->done(QWizard::Accepted);
_ocWizard->done(result);
emit ownCloudWizardDone(result);

Check warning on line 703 in src/gui/owncloudsetupwizard.cpp

View workflow job for this annotation

GitHub Actions / build

src/gui/owncloudsetupwizard.cpp:703:10 [cppcoreguidelines-init-variables]

variable 'ownCloudWizardDone' is not initialized
}

Expand All @@ -709,7 +709,10 @@ void OwncloudSetupWizard::slotSkipFolderConfiguration()

disconnect(_ocWizard, &OwncloudWizard::basicSetupFinished,
this, &OwncloudSetupWizard::slotAssistantFinished);
_ocWizard->close();

_ocWizard->done(QDialog::Rejected);

// Accept to check connectivity, only skip folder setup
emit ownCloudWizardDone(QDialog::Accepted);

Check warning on line 716 in src/gui/owncloudsetupwizard.cpp

View workflow job for this annotation

GitHub Actions / build

src/gui/owncloudsetupwizard.cpp:716:10 [modernize-use-trailing-return-type]

use a trailing return type for this function
}

Expand Down

0 comments on commit 0b58b47

Please sign in to comment.