Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add PHP 8.4 #4186

Merged
merged 1 commit into from
Oct 24, 2024
Merged

chore: add PHP 8.4 #4186

merged 1 commit into from
Oct 24, 2024

Conversation

SebastianKrupinski
Copy link
Contributor

Fingers crossed

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.33%. Comparing base (6932f28) to head (5a6e006).
Report is 176 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4186      +/-   ##
============================================
+ Coverage     65.90%   66.33%   +0.42%     
- Complexity      261      263       +2     
============================================
  Files            24       25       +1     
  Lines           786      799      +13     
============================================
+ Hits            518      530      +12     
- Misses          268      269       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: SebastianKrupinski <[email protected]>
@hamza221
Copy link
Contributor

this is missing

"php": ">=7.4 <=8.3"

@SebastianKrupinski
Copy link
Contributor Author

this is missing

"php": ">=7.4 <=8.3"

Just checked our other groupware apps. We haven't increased the max php versions in the composer on them yet, and probably because its not fully released yet.

@SebastianKrupinski SebastianKrupinski merged commit d551550 into main Oct 24, 2024
32 checks passed
@SebastianKrupinski SebastianKrupinski deleted the chore/add-php-8.4 branch October 24, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants