Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rtl): navigation buttons #6416

Merged
merged 1 commit into from
Oct 29, 2024
Merged

fix(rtl): navigation buttons #6416

merged 1 commit into from
Oct 29, 2024

Conversation

hamza221
Copy link
Contributor

@hamza221 hamza221 commented Oct 11, 2024

@hamza221 hamza221 added 3. to review Waiting for reviews bug design Related to design, interface, interaction design, UX, etc. skill:frontend Issues and PRs that require JavaScript/Vue/styling development skills labels Oct 11, 2024
@hamza221 hamza221 self-assigned this Oct 11, 2024
@hamza221
Copy link
Contributor Author

@DorraJaouad Can you please test this, I'm not sure how it's supposed to work UX wise. I switched the buttons but it feels wrong

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 23.52%. Comparing base (dac1c26) to head (4f88b3c).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...NavigationHeader/AppNavigationHeaderDatePicker.vue 0.00% 11 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6416      +/-   ##
============================================
- Coverage     23.56%   23.52%   -0.04%     
  Complexity      454      454              
============================================
  Files           247      247              
  Lines         11693    11711      +18     
  Branches       2205     2221      +16     
============================================
  Hits           2755     2755              
- Misses         8618     8636      +18     
  Partials        320      320              
Flag Coverage Δ
javascript 15.06% <0.00%> (-0.03%) ⬇️
php 59.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hamza221
Copy link
Contributor Author

@DorraJaouad are you on latest master (server) ?

@DorraJaouad
Copy link

@DorraJaouad are you on latest master (server) ?

No, master is now updated 🙈

The directions should be the opposite (e.g: left side button leads to next month)

Recording.2024-10-12.165218.mp4

@hamza221 hamza221 force-pushed the Fix/6402/rtl branch 2 times, most recently from bd4a18e to 8a6536c Compare October 24, 2024 12:22
Copy link

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested

Signed-off-by: Hamza Mahjoubi <[email protected]>
@st3iny st3iny added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 29, 2024
@st3iny st3iny added this to the v5.1.0 milestone Oct 29, 2024
@st3iny st3iny enabled auto-merge October 29, 2024 16:00
Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Was tested by a native speaker.

@st3iny st3iny merged commit b9f2b33 into main Oct 29, 2024
34 of 36 checks passed
@st3iny st3iny deleted the Fix/6402/rtl branch October 29, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug design Related to design, interface, interaction design, UX, etc. skill:frontend Issues and PRs that require JavaScript/Vue/styling development skills
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navigation buttons should be flipped
3 participants