-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(rtl): navigation buttons #6416
Conversation
@DorraJaouad Can you please test this, I'm not sure how it's supposed to work UX wise. I switched the buttons but it feels wrong |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6416 +/- ##
============================================
- Coverage 23.56% 23.52% -0.04%
Complexity 454 454
============================================
Files 247 247
Lines 11693 11711 +18
Branches 2205 2221 +16
============================================
Hits 2755 2755
- Misses 8618 8636 +18
Partials 320 320
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@DorraJaouad are you on latest master (server) ? |
No, master is now updated 🙈 The directions should be the opposite (e.g: left side button leads to next month) Recording.2024-10-12.165218.mp4 |
bd4a18e
to
8a6536c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested
Signed-off-by: Hamza Mahjoubi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Was tested by a native speaker.
fix #6402