feat: Allow shared calendars as appointment conflict calendars #6411
+52
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SebastianKrupinski
requested review from
miaulalala,
st3iny and
tcitworld
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6411 +/- ##
=========================================
Coverage 23.47% 23.48%
Complexity 454 454
=========================================
Files 247 247
Lines 11708 11716 +8
Branches 2212 2224 +12
=========================================
+ Hits 2749 2752 +3
- Misses 8639 8644 +5
Partials 320 320
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
miaulalala
approved these changes
Nov 4, 2024
Signed-off-by: SebastianKrupinski <[email protected]>
Signed-off-by: SebastianKrupinski <[email protected]>
SebastianKrupinski
force-pushed
the
feat/issue-3786-allow-shared-calendars
branch
from
562e828
to
2182d38
Compare
Signed-off-by: SebastianKrupinski <[email protected]>
@ChristophWurst Done. Please have another look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #3786
Requires: nextcloud/server#48621
Summary
Adjusted "Additional calendars to check for conflicts" selection logic to list all users calendars, personal and shared to be selectable for conflicts.