Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sync calendar instantly on changes #6364

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

st3iny
Copy link
Member

@st3iny st3iny commented Sep 23, 2024

This approach requires notify_push.

@st3iny st3iny added 2. developing Work in progress enhancement New feature request labels Sep 23, 2024
@st3iny st3iny self-assigned this Sep 23, 2024
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 31 lines in your changes missing coverage. Please review.

Project coverage is 29.18%. Comparing base (bd73f27) to head (97948db).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
src/store/calendars.js 0.00% 16 Missing and 2 partials ⚠️
src/services/notifyService.js 0.00% 10 Missing and 1 partial ⚠️
src/views/Calendar.vue 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6364      +/-   ##
============================================
+ Coverage     23.54%   29.18%   +5.63%     
- Complexity      454      916     +462     
============================================
  Files           247      291      +44     
  Lines         11700    13988    +2288     
  Branches       2203     2204       +1     
============================================
+ Hits           2755     4082    +1327     
- Misses         8625     9583     +958     
- Partials        320      323       +3     
Flag Coverage Δ
javascript 15.05% <0.00%> (-0.03%) ⬇️
php 58.97% <ø> (-0.56%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tcitworld
Copy link
Member

This is nice, but I feel working with Sabre's DAV Push to use WebPush would be half the work and bring the same functionality to 3rd-party clients for the same cost?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress enhancement New feature request
Projects
Status: 🏗️ In progress
Development

Successfully merging this pull request may close these issues.

2 participants